Skip to content

Conversation

@Tugzrida
Copy link
Contributor

As php casts the boolean false to the empty string, which is not a valid value for go's strconv.ParseBool, it was not possible to set skipNetworkIdleEvent to false.

This change uses the explicit strings 'true' and 'false' instead to ensure the correct value is passed on the wire.

@gulien
Copy link
Contributor

gulien commented Feb 12, 2025

Thanks for the heads up @Tugzrida!

Co-authored-by: Julien Neuhart <neuhart.julien@gmail.com>
@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (dce958d) to head (62d4fb3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #57   +/-   ##
=========================================
  Coverage     95.00%   95.00%           
- Complexity      175      176    +1     
=========================================
  Files            17       17           
  Lines           500      500           
=========================================
  Hits            475      475           
  Misses           25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gulien gulien merged commit e7f36af into gotenberg:main Feb 12, 2025
7 checks passed
@gulien
Copy link
Contributor

gulien commented Feb 12, 2025

Thanks @Tugzrida!

@Tugzrida Tugzrida deleted the patch-1 branch February 12, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants