feat: Add support for the header id feature #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hectorhammett
force-pushed
the
header-id
branch
from
e83b1d4 to
6d08aa6
Compare
aandreassa
requested changes
Jan 28, 2026
Contributor
aandreassa
left a comment
aandreassa
left a comment
There was a problem hiding this comment.
LG! Please also fix rubocop issues.
google-cloud-spanner/lib/google/cloud/spanner/request_id_interceptor.rb
Outdated
Show resolved
Hide resolved
google-cloud-spanner/lib/google/cloud/spanner/request_id_interceptor.rb
Outdated
Show resolved
Hide resolved
Hectorhammett
force-pushed
the
header-id
branch
from
111e88e to
29389ed
Compare
aandreassa
requested changes
Jan 29, 2026
Contributor
aandreassa
left a comment
aandreassa
left a comment
There was a problem hiding this comment.
Few minor requests! Thank you
aandreassa
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Spanner's new feature to add a header id to each rpc request for easy debugging. This will help communication between the end user and the Spanner team when debugging is necessary.
b/446013273