[codegen 1.5] Fix register cleanup pass if all writes are no-ops #3691
+13
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_856781702
branch
from
2718f89 to
8715cc2
Compare
In this case, we try to remove the register - but we forgot to clean up the writes, resulting in an error when we tried to remove the register. PiperOrigin-RevId: 857162262
copybara-service
bot
force-pushed
the
test_856781702
branch
from
8715cc2 to
7bd0170
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[codegen 1.5] Fix register cleanup pass if all writes are no-ops
In this case, we try to remove the register - but we forgot to clean up the writes, resulting in an error when we tried to remove the register.