[Proc-scoped channels] In ir converter main, if the lower_to_proc_scoped_channels flag is specified at all, use it. Otherwise, use false (instead of the default in ConvertOptions). This will allow targets to force the flag to "false" even if the default is true.
#3663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_853379668
branch
2 times, most recently
from
5a9ceff to
4f51bfc
Compare
…oped_channels` flag is specified at all, use it. Otherwise, use false (instead of the default in ConvertOptions). This will allow targets to force the flag to "false" even if the default is true. Updated most BUILD files that use `xls_dslx_ir` to specify the flag as true or false instead of defaulting to the default when it's not specified. PiperOrigin-RevId: 853379668
copybara-service
bot
force-pushed
the
test_853379668
branch
from
4f51bfc to
21d8ebf
Compare
copybara-service
bot
changed the title
lower_to_proc_scoped_channels flag is specified, use it. Otherwise, use false (instead of the default in ConvertOptions).lower_to_proc_scoped_channels flag is specified at all, use it. Otherwise, use false (instead of the default in ConvertOptions). This will allow targets to force the flag to "false" even if the default is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Proc-scoped channels] In ir converter main, if the
lower_to_proc_scoped_channelsflag is specified at all, use it. Otherwise, use false (instead of the default in ConvertOptions). This will allow targets to force the flag to "false" even if the default is true.Updated most BUILD files that use
xls_dslx_irto specify the flag as true or false instead of defaulting to the default when it's not specified.