Have _graph_flatten respect nnx.data declarations #5136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5128
According to the documentation, attributes of Modules that are Arrays, Variables, other Modules, or annotated with
nnx.datashould all show up as children when the parent module is flattened.Currently, this is only true in flax when it comes to Jax's flattening system. In the NNX graph flattening system, we actually follow somewhat different rules. I'm not entirely sure how this system works (as there's lots of mutable state involved), but it roughly seems like the leaf nodes we get when flattening are just descent Variable and Array nodes. Nnx.data declarations don't do anything at all in Flax's graph flattening system.
This PR attempts to make Flax's graph flattening system work more like Jax's tree flattening one.