Skip to content

Conversation

@TheRealHaui
Copy link

Added a Unit Test to increase code coverage

@eamonnmcmanus
Copy link
Member

Thanks!

I'm all for increasing code coverage, but I wonder if the same effect might be achieved more simply by adding a new test method to TemplateTest. I think the idea here is that the in parameter to ForEachNode isn't iterable, which should get an exception. Could we test evaluating a template like this?

#foreach ($i in 2853)
#if (2853) 2853 #else 2853 #end
#end

I think that's equivalent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants