(torax): Issue#1358 Add dynamic variable access to PlotData class
#1874
+150
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jcitrin , take a look !! |
jcitrin
reviewed
Jan 5, 2026
Collaborator
jcitrin
left a comment
jcitrin
left a comment
There was a problem hiding this comment.
My one main comment is that we can relax a bit the requirement for backwards compatibility in plotruns_lib. What needs to be backwards compatible is only the configs in plotting/configs. If plotruns_lib_test passes, then we should be OK. The specific in-line comments are all in this direction:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Enables
PlotDatato dynamically access any variable from output datasets, not just hardcoded attributes.Previously,
PlotDataonly supported predefined attributes (T_i, T_e, n_e, etc.). Users couldn't plot custom diagnostic variables from output files without modifying the class. This PR solves this issue.Issue Solved #1358