Improve j_total calculation to avoid numerical artifacts. #1872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_851467895
branch
2 times, most recently
from
5341c30 to
03867ee
Compare
Calculate j_total on the cell grid from finite differences of Ip_profile face. This significantly improves smoothness particularly towards the boundaries. Minor differences in some integration test cases on order of O(1e-3) due to different ohmic heating. PiperOrigin-RevId: 852211436
copybara-service
bot
force-pushed
the
test_851467895
branch
from
03867ee to
2923d37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve j_total calculation to avoid numerical artifacts.
Calculate j_total on the cell grid from finite differences of Ip_profile face. This significantly improves smoothness particularly towards the boundaries.
Minor differences in some integration test cases on order of O(1e-3) due to different ohmic heating.