Extrapolate chi_neo_e and V_neo_ware_e #1831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theo-brown
added
bug
jcitrin
reviewed
Dec 9, 2025
Collaborator
jcitrin
left a comment
jcitrin
left a comment
There was a problem hiding this comment.
For consistency in pattern, should do this bulk+axis extrapolation for all the Neoclassical transport outputs.
And then would need to fix the tests (I guess the issue is the unit test + relevant sim_tests that used this)
theo-brown
force-pushed
the
extrapolate-neoclassical-axis-values
branch
from
f55e941 to
991d1fc
Compare
jcitrin
approved these changes
Dec 10, 2025
jcitrin
added
the
copybara:import-manual
Collaborator
|
@theo-brown could you please sync this one to main? There will be some merge conflicts due to changes done on top of the Shaing PR following internal review. Thanks! Then we'll bring it in too. |
theo-brown
force-pushed
the
extrapolate-neoclassical-axis-values
branch
from
991d1fc to
426c9ad
Compare
jcitrin
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1830
Before, without V_e clamped to 0 in neoclassical - causes sim crash due to unphysical density peaking.
Before, with V_e clamped to 0 in neoclassical - note on-axis peak in chi_e (only has a cosmetic effect)
After
