Add a time filter to upcoming orders page #2358
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@m-amaya this seems to only filter out orders from the existing listing. If I wanted to look at the orders for tomorrow or yesterday (or any arbitrary date in the past or future), it gives me an empty list. This would need some server-side changes in order to make it possible to query for different days. We can't load all orders from all time into memory (unlike with the restaurant listing). |
Member
|
also it's a little weird to position the fields as "Start date, end date, start time, end time" instead of "Start date, start time, end date, end time" but that's not important. |
Contributor
Author
|
I'm going to hold off on this issue until after the query route is fixed. it'll fix all the issues you've mentioned @L8D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.