Skip to content

Conversation

@Lslightly
Copy link
Contributor

@Lslightly Lslightly commented Aug 17, 2025

Add followExec and followExecRegex options in launch request in
launch.json. Before InitializedEvent is sent back from delve, followExec
and followExecRegex will be set in delve. If the program being
debugged spawns a new child process at the beginning and
breakpoints are set in source code line of child process, these
breakpoints will be hit and shown to the user.

Without these two options, although go-delve/delve#4078 provides
delve command to enable follow-exec in console, user have to
manually enable follow-exec in console each time launching the
debug session.

Fixes #3712

@gopherbot
Copy link
Collaborator

This PR (HEAD: 2532b54) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/696795.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Collaborator

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/696795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Qingwei Li:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/696795.
After addressing review feedback, remember to publish your drafts!

@Lslightly Lslightly force-pushed the dap-enable-follow-exec branch from 2532b54 to c4879dd Compare December 7, 2025 02:32
@gopherbot
Copy link
Collaborator

This PR (HEAD: c4879dd) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/696795.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@Lslightly Lslightly marked this pull request as ready for review December 7, 2025 02:45
@gopherbot
Copy link
Collaborator

This PR (HEAD: c9f186c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/696795.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Collaborator

Message from Qingwei Li:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/696795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hongxiang Jiang:

Patch Set 4: Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/696795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-07T08:16:14Z","revision":"fd5f40b43fb6aa7d6363e17b64c6bdf2e5bfc419"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/696795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hongxiang Jiang:

Patch Set 4: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/696795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/x_vscode-go-gotip-linux-amd64_docker has failed with summary (view all results):


To reproduce, try gomote repro 8696157060227690897.

Additional links for debugging:


Please don’t reply on this GitHub thread. Visit golang.org/cl/696795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1


Please don’t reply on this GitHub thread. Visit golang.org/cl/696795.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add support for debugging child process enabled by delve backend

2 participants