Contribute improvements back upstream

[ZimbiX]

Hey folks!

You don't have issues enabled on this repo, so I've had to open a PR for this discussion.

We at @greensync have taken over maintenance of Que, the upstream project of your fork =) I went through the forks a couple of months ago to see if there were any useful changes to bring in, but somehow I missed this one! I see you folks have made a whole bunch of improvements, which is fantastic! Now that the upstream project is actively being maintained again, I was hoping you'd be open to helping combine your improvements back upstream?

Sadly, your fork is of such an old version of Que that integrating the changes back upstream is probably going to be a bit of a challenge now. I'm curious - why did you feel the need to fork rather than become maintainers? We faced that choice ourselves, but opted to try for the latter, and thankfully it was approved.

I'd like to start by enumerating what the improvements have been. I see you've added Prometheus metrics, which would be quite handy. An issue was opened two years ago by one of you suggesting contributing that (and other improvements) upstream (que-rb/que#267) which I've just noticed.

I think we should open an issue for each feature, and then create a PR for each one. Probably best to branch from our Ruby 3 PR where suitable, as there's a few changes there and it's almost good to go: que-rb/que#319.

Cheers,

-Brendan

[stephenbinns]

Hi @ZimbiX sorry for the delay getting back to you - the historic reasons behind the forking are down to us taking a different approach to retries - que-rb/que#106 we're in the same sort of position as you with wanting to merge features from upstream into our branch. I will investigate internally about if we could potentially push these features back upstream to you as this does reduce the effort involved in if we wanted to stop using the fork.