1004 persist windows size

[AdiAr11]

Pull Request Details

Associated Issue

• This PR relates to issue SETTINGS: Persist window size #1004

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Ran the application and manually tested the feature implementation

Checklist

Complete the check-list below to ensure your branch is ready for PR.

• Screenshots included in linked issue #
• Changes adhere to the style and coding guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• Any dependent changes have been merged and published in downstream modules
• The update contains no confidential information
• The update has no duplicated content
• No lint check errors are related to these changes (make prep or flutter analyze lib)
• Integration test dart test output or screenshot included in issue #
• I tested the PR on these devices:
  • Android
  • iOS
  • Linux
  • MacOS
  • Windows
  • Web
• I have identified two reviewers
• The PR has been approved by two reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

• Merge dev into the this branch
• Resolve any conflicts
• Add a one line summary into the CHANGELOG.md
• Push to the git repository and review
• Merge the PR into dev

[AdiAr11]

I'll fix the lint issues as well :)

[gjwgit]

Thanks for the PR @AdiAr11 - looks good. Tested on Linux.

Needs lint fixes

[gjwgit]

There are a few lint issues that require attention.

[gjwgit]

Tested. Ready to be merged once the lint issues are fixed.

[AdiAr11]

Hi @gjwgit, there's only one lint issue left which is not passing: Don't use 'BuildContext's across async gaps • lib/widgets/close_dialog.dart:141:18 • use_build_context_synchronously
This was already present in the code though. Should I fix it or let it be?

[gjwgit]

Hi @gjwgit, there's only one lint issue left which is not passing: Don't use 'BuildContext's across async gaps • lib/widgets/close_dialog.dart:141:18 • use_build_context_synchronously This was already present in the code though. Should I fix it or let it be?

Yes, the code was already there but the extra code you added has introduced an async gap. Try adding if (mounted) before the Navigator.of(context)....