Skip to content

Conversation

@Young-TW
Copy link
Contributor

@Young-TW Young-TW commented Jan 7, 2026

Adds .slurm and .sbatch as extensions to the Shell language.

Description

These extensions are widely used in High Performance Computing (HPC) environments for submitting batch jobs to the Slurm Workload Manager. While they contain Slurm-specific #SBATCH directives, the syntax is fundamentally valid Shell (Bash/Sh) script.

Checklist:

@Young-TW Young-TW requested a review from a team as a code owner January 7, 2026 16:37
@lildude
Copy link
Member

lildude commented Jan 7, 2026

I'm not sure this is really needed as it appears all files based on your search queries have a shebang and thus are already automatically classified as shell.

@Young-TW
Copy link
Contributor Author

Young-TW commented Jan 7, 2026

That is true for best practices, but sbatch allows running scripts without a shebang. In those cases, GitHub currently classifies them as Plain Text. This change ensures correct syntax highlighting even when the shebang is omitted.

@lildude
Copy link
Member

lildude commented Jan 7, 2026

That is true for best practices, but sbatch allows running scripts without a shebang. In those cases, GitHub currently classifies them as Plain Text. This change ensures correct syntax highlighting even when the shebang is omitted.

Can you please update your search queries to illustrate this.

@Young-TW
Copy link
Contributor Author

Young-TW commented Jan 7, 2026

I have updated the PR description with new search queries.

I used the -language:Shell filter. This explicitly reveals .slurm and .sbatch files that contain #SBATCH directives but are not currently recognized as Shell by Linguist (due to missing shebangs).

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Important

The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.

@lildude lildude added this pull request to the merge queue Jan 8, 2026
Merged via the queue into github-linguist:main with commit caea995 Jan 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants