-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Add aliases to glimmer-js and glimmer-ts #7732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lildude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment.
4608bf1 to
3877b92
Compare
|
I have a question. In the (Currently on GitHub, code blocks with |
No. The The
Codeblocks are rendered using the markup library which feeds off linguist, but isn't really maintained much these days. I'm not very familiar with this how markup works, but this should improve things. |
lildude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Important
The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.
|
@lildude Thank you for your prompt response and help with looking into what may be happening differently between |

Description
Patches #6630 and #6680.
While the terms "Glimmer JS" and "Glimmer TS" do currently appear in public repos in the context of parsers, I think these terms are technical and not what Ember developers would colloquially refer to files with
<template>tags. Rather, we refer togjsandgts, respectively.Example: Ember's official tutorial doesn't mention "Glimmer JS" or "Glimmer TS."
Examples of more technical documentations:
I added the
aliaseskey to these 2 languages, in particular, to ease writing code blocks on GitHub. Once this pull request is approved and released, developers would be able to write the following:Checklist: