Skip to content

Conversation

@ijlee2
Copy link
Contributor

@ijlee2 ijlee2 commented Jan 5, 2026

Description

Patches #6630 and #6680.

While the terms "Glimmer JS" and "Glimmer TS" do currently appear in public repos in the context of parsers, I think these terms are technical and not what Ember developers would colloquially refer to files with <template> tags. Rather, we refer to gjs and gts, respectively.

Example: Ember's official tutorial doesn't mention "Glimmer JS" or "Glimmer TS."

Examples of more technical documentations:

I added the aliases key to these 2 languages, in particular, to ease writing code blocks on GitHub. Once this pull request is approved and released, developers would be able to write the following:

- ```glimmer-js
+ ```gjs
const Hello = <template>
  <div>Hello, {{@name}}!</div>
</template>;

export default Hello;
```
- ```glimmer-ts
+ ```gts
interface HelloSignature {
  Args: {
    name: string;
  }
}

const Hello: HelloSignature = <template>
  <div>Hello, {{@name}}!</div>
</template>;

export default Hello;
```

Checklist:

  • I am adding new or changing current functionality
    • I have added or updated the tests for the new or changed functionality.

@ijlee2 ijlee2 requested a review from a team as a code owner January 5, 2026 15:30
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

@ijlee2 ijlee2 force-pushed the alias-for-glimmer branch from 4608bf1 to 3877b92 Compare January 5, 2026 15:35
@ijlee2 ijlee2 requested a review from lildude January 5, 2026 15:41
@ijlee2
Copy link
Contributor Author

ijlee2 commented Jan 5, 2026

I have a question. In the main branch, lib/linguist/languages.yml#L3684 lists gjs as a possible interpreter for JavaScript (introduced in #4783). Would this create a conflict with the alias gjs for *.gjs files?

(Currently on GitHub, code blocks with gjs language do get syntax highlighting, but not gts. I wonder if the discrepancy in behavior is due to gjs having been listed in interpreters.)

@lildude
Copy link
Member

lildude commented Jan 8, 2026

Would this create a conflict with the alias gjs for *.gjs files?

No. The gjs codeblocks are being correctly rendered due to the Glimmer JS entry as this is the only language with this extension.

The gts blocks are being detected as Gerber because there are two languages with this extension but it appears the heuristic isn't being used to differentiate so it's going on the first result for some reason:

Screenshot 2026-01-08 at 10 01 31

Codeblocks are rendered using the markup library which feeds off linguist, but isn't really maintained much these days. I'm not very familiar with this how markup works, but this should improve things.

@lildude lildude changed the title Defined aliases of glimmer-js and glimmer-ts Add aliases to glimmer-js and glimmer-ts Jan 8, 2026
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Important

The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.

@lildude lildude added this pull request to the merge queue Jan 8, 2026
Merged via the queue into github-linguist:main with commit dea1d55 Jan 8, 2026
5 checks passed
@ijlee2
Copy link
Contributor Author

ijlee2 commented Jan 8, 2026

@lildude Thank you for your prompt response and help with looking into what may be happening differently between gjs and gts. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants