Skip to content

Conversation

@nickswalker
Copy link
Contributor

Description

.p is a common file extension which is getting mapped to OpenEdge ABL in most cases (except when matching a pattern for GNUplot files). This has been raised several times ( #4216, #4074, #3835, #3619, #1277). This PR adds patterns to prevent this. I also added a pattern for the language under the .cls extension, as it was similar and there were already samples in the repo.

There were already two OpenEdge .p samples, but one was a single-line hello world. I have replaced this sample.

Checklist:

Adds pattern for OpenEdge ABL's *.p association
Add extra .p sample
@nickswalker nickswalker requested a review from a team as a code owner December 31, 2025 01:18
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

Use non-capturing groups
@nickswalker nickswalker requested a review from lildude January 4, 2026 22:01
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Important

The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.

@lildude lildude added this pull request to the merge queue Jan 8, 2026
Merged via the queue into github-linguist:main with commit 7434c16 Jan 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants