Improve detection of ASP and LP files #7716
Merged
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Answer Set Programming was patternless, leading to many false positives. Now, it now matches files containing specific ASP directives (`#include`, `#const`, etc.). Additionally, it looks for rules defined with `:-`. Added an ASP sample `tohB.lp` from Potassco's clingo repo (MIT licensed). Lacks `#` directives, so serves to make sure second pattern works
nickswalker
force-pushed
the
improve-lp-asp-patterns
branch
from
9dacd44 to
0590503
Compare
lildude
requested changes
Jan 8, 2026
Member
lildude
left a comment
lildude
left a comment
There was a problem hiding this comment.
See inline comment.
Additionally, we need tests for all heuristics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pattern for Answer Set Programming.
Description
Answer Set Programming (#7184) was patternless, leading to false positives on LibrePCB .lp files (which don't appear popular enough for inclusion themselves). Now, it now matches files containing specific ASP directives (
#include,#const, etc.). Because some ASP files won't have directives, it also looks for rules defined with:-, or lines simply containing "facts" (foo(x).oratom.oredge(2, 4).).Added an additional ASP sample
tohB.lpfrom Potassco's clingo repo (MIT licensed) to exercise the patterns.Checklist: