Skip to content

Conversation

@krlvi
Copy link
Member

@krlvi krlvi commented Jan 15, 2026

Copilot AI review requested due to automatic review settings January 15, 2026 01:13
@vercel
Copy link

vercel bot commented Jan 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
gitbutler-web Ignored Ignored Preview Jan 15, 2026 2:45am

@github-actions github-actions bot added the rust Pull requests that update Rust code label Jan 15, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the deprecated head field from the Stack struct and related methods across the codebase. The field has been superseded by the heads list which provides a more complete representation of stack state.

Changes:

  • Removed the head field from the active Stack struct definition while maintaining it in legacy serialization types for backward compatibility
  • Removed the set_head() method which was no longer used
  • Updated Stack::new() and Stack::create() to remove the head parameter
  • Refactored make_new_empty_reference() to compute head values inline using head_oid()

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
crates/gitbutler-stack/src/stack.rs Removed deprecated head field, set_head() method, and refactored logic to use head_oid() instead
crates/but-meta/src/virtual_branches_legacy_types.rs Moved head field to deprecated section with proper serialization defaults for backward compatibility
crates/gitbutler-branch-actions/src/branch_manager/branch_creation.rs Updated Stack::create() calls to remove head parameter and cleaned up unused variable
crates/gitbutler-branch-actions/src/base.rs Updated Stack::create() call to remove head parameter

Copilot AI review requested due to automatic review settings January 15, 2026 02:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants