-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
chore(top-issues): add more actions #104467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
93a11c2 to
b1b395f
Compare
| substatus: GroupSubstatus.ARCHIVED_UNTIL_ESCALATING, | ||
| }, | ||
| project: selection.projects, | ||
| environment: selection.environments, | ||
| ...selection.datetime, | ||
| }, | ||
| {} | ||
| ); | ||
| }, | ||
| }); | ||
| }, [api, cluster.group_ids, organization.slug, selection]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Bulk resolve/archive operations ignore date filters because query parameter is missing when selection.datetime is passed to bulkUpdate.
Severity: HIGH | Confidence: High
🔍 Detailed Analysis
The bulkUpdate calls within handleResolve and handleArchive in dynamicGrouping.tsx pass selection.datetime but omit the query parameter. The internal paramsToQueryArgs function, which processes these parameters, only includes date filters (start, end, period, utc) when a query parameter is present. As a result, the user's selected date range filters will be ignored, causing bulk resolve and archive operations to apply to all issues in the cluster, rather than only those within the specified date range. This leads to operations affecting more issues than the user intended.
💡 Suggested Fix
Ensure handleResolve and handleArchive pass a query parameter (e.g., selection.query) along with selection.datetime to bulkUpdate to enable date filter application.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: static/app/views/issueList/pages/dynamicGrouping.tsx#L389-L441
Potential issue: The `bulkUpdate` calls within `handleResolve` and `handleArchive` in
`dynamicGrouping.tsx` pass `selection.datetime` but omit the `query` parameter. The
internal `paramsToQueryArgs` function, which processes these parameters, only includes
date filters (`start`, `end`, `period`, `utc`) when a `query` parameter is present. As a
result, the user's selected date range filters will be ignored, causing bulk resolve and
archive operations to apply to all issues in the cluster, rather than only those within
the specified date range. This leads to operations affecting more issues than the user
intended.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 5888438
Add resolve, archive, and dismiss to clusters. Dismiss intentionally doesn't do anything here yet.