Skip to content

Conversation

@cvxluo
Copy link
Contributor

@cvxluo cvxluo commented Dec 5, 2025

Add resolve, archive, and dismiss to clusters. Dismiss intentionally doesn't do anything here yet.

@cvxluo cvxluo marked this pull request as ready for review December 5, 2025 19:16
@cvxluo cvxluo requested a review from a team as a code owner December 5, 2025 19:16
@cvxluo cvxluo requested a review from a team December 5, 2025 19:16
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 5, 2025
Comment on lines +431 to +441
substatus: GroupSubstatus.ARCHIVED_UNTIL_ESCALATING,
},
project: selection.projects,
environment: selection.environments,
...selection.datetime,
},
{}
);
},
});
}, [api, cluster.group_ids, organization.slug, selection]);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Bulk resolve/archive operations ignore date filters because query parameter is missing when selection.datetime is passed to bulkUpdate.
Severity: HIGH | Confidence: High

🔍 Detailed Analysis

The bulkUpdate calls within handleResolve and handleArchive in dynamicGrouping.tsx pass selection.datetime but omit the query parameter. The internal paramsToQueryArgs function, which processes these parameters, only includes date filters (start, end, period, utc) when a query parameter is present. As a result, the user's selected date range filters will be ignored, causing bulk resolve and archive operations to apply to all issues in the cluster, rather than only those within the specified date range. This leads to operations affecting more issues than the user intended.

💡 Suggested Fix

Ensure handleResolve and handleArchive pass a query parameter (e.g., selection.query) along with selection.datetime to bulkUpdate to enable date filter application.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/views/issueList/pages/dynamicGrouping.tsx#L389-L441

Potential issue: The `bulkUpdate` calls within `handleResolve` and `handleArchive` in
`dynamicGrouping.tsx` pass `selection.datetime` but omit the `query` parameter. The
internal `paramsToQueryArgs` function, which processes these parameters, only includes
date filters (`start`, `end`, `period`, `utc`) when a `query` parameter is present. As a
result, the user's selected date range filters will be ignored, causing bulk resolve and
archive operations to apply to all issues in the cluster, rather than only those within
the specified date range. This leads to operations affecting more issues than the user
intended.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 5888438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants