-
Notifications
You must be signed in to change notification settings - Fork 570
feat(ai): add single message truncation #5079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ai): add single message truncation #5079
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in terms of the general approach.
The message mutation also to be addressed; we should not edit the return value of another library and return the edited value to the user.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5079 +/- ##
==========================================
+ Coverage 84.17% 84.21% +0.04%
==========================================
Files 181 181
Lines 18443 18459 +16
Branches 3283 3287 +4
==========================================
+ Hits 15524 15546 +22
+ Misses 1904 1895 -9
- Partials 1015 1018 +3
|
| if result: | ||
| assert result[-1] == large_messages[-1] | ||
| assert result[-1] == large_messages[-1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the if result because result always has at least one element due to this PR.
Truncate the message list to
Contributes to TET-1208