feat: on appeal or failure revert it to the previous value #1240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling - Implement value transfer between accounts in consensus - Add error handling for insufficient balance in transactions - Update GenVM to support transaction value parameter - Add automatic account funding when creating new accounts in frontend - Add error handling for transaction processing in RPC endpoints - Update frontend components to handle account creation asynchronously
… into 1028-feat-adjust-value-in-current_state-based-on-transaction-values
…d-on-transaction-values
… add value checks in testcase
…d-on-transaction-values
Contributor
WalkthroughThis change set introduces unified and explicit handling of account balances and transaction values across the backend, frontend, smart contracts, and tests. It revises balance update logic, adds error handling, enables value transfer with contract calls, updates interfaces to support these features, and synchronizes contract and account state management in tests. Frontend components and services are extended to support account funding and value input for contract calls. Changes
Sequence Diagram(s)Value Transfer During Contract ExecutionsequenceDiagram
participant User
participant Frontend
participant Backend (RPC)
participant AccountsManager
participant Node
participant GenVMHost
User->>Frontend: Initiate contract call (with value)
Frontend->>Backend (RPC): send_raw_transaction / callWriteMethod (with value)
Backend (RPC)->>AccountsManager: update_account_balance(sender, -value)
AccountsManager-->>Backend (RPC): Success/Failure
Backend (RPC)->>Node: run_contract(..., transaction_value=value)
Node->>GenVMHost: run_contract(..., value)
GenVMHost-->>Node: Execution result
Node-->>Backend (RPC): Receipt
Backend (RPC)-->>Frontend: Response
Frontend-->>User: Show result
Account Creation and FundingsequenceDiagram
participant User
participant Frontend
participant JsonRpcService
participant Backend (RPC)
participant AccountsManager
participant ConsensusService
User->>Frontend: Create new account
Frontend->>JsonRpcService: generateNewAccount()
JsonRpcService->>Backend (RPC): Create account
Backend (RPC)->>AccountsManager: create_new_account_with_address()
AccountsManager->>ConsensusService: fund_hardhat_account(address, amount)
ConsensusService-->>AccountsManager: Done
AccountsManager-->>Backend (RPC): Account created
Backend (RPC)-->>JsonRpcService: Account info
JsonRpcService-->>Frontend: Account info
Frontend-->>User: Notify account created
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
kstroobants
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…saction-values into dxp-170-feat-on-appeal-or-failure-revert-it-to-the-previous-value
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #DXP-170
What
restore_stuck_transactionsfunction to include balance restoration logic.test_base.pyto verify the new refund functionality.Why
To ensure that the recipient's account balance is correctly restored when a validator appeal is successful.
Testing done
Added and executed unit tests in
test_base.pyto verify that account balances are correctly restored after successful appeals.Decisions made
Checks
Reviewing tips
Focus on the changes.
Depends
This PR contains code from PR #1036
User facing release notes
Implemented restoring of the contract balance when appealed or recomputed.
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Chores
Tests