fix: Improve CreateChatModal with proper agent ordering and simpler UI #690
Conversation
- Add AgentDropdown component for simple single-agent selection - Use agentConfig order for consistent agent listing (Claude first) - Respect user's default agent setting when pre-selecting - Change label from 'Select AI Agent' to 'Agent' for consistency - Change button from 'Create Chat' to 'Create' for consistency - Remove unused props (installedProviders, currentProvider) - Fix MultiAgentDropdown to preserve agentConfig order
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| }); | ||
| } | ||
| }, [isOpen, currentProvider, installedProviders, usedAgents]); | ||
| }, [isOpen, usedAgents]); |
There was a problem hiding this comment.
Missing cleanup for async effect causes potential race condition
Low Severity
The useEffect that loads settings via window.electronAPI.getSettings() lacks a cleanup function and cancel guard. TaskModal uses the correct pattern with let cancel = false and a cleanup that sets cancel = true, checking if (cancel) return before state updates. Without this, if the modal closes/reopens quickly or usedAgents changes while the promise is pending, stale callbacks can update state incorrectly, causing race conditions where the wrong agent gets selected.
Changes
AgentDropdowncomponent for simple single-agent selection (no multi-run selector, no tooltips)agentConfigorder for consistent agent listing (Claude Code first)MultiAgentDropdownto preserveagentConfigorder instead of custom sortingNote
Streamlines chat creation and enforces consistent agent ordering.
AgentDropdownfor single-agent selection with logos and disabled states for agents already in useCreateChatModalto useAgentDropdown, preselects from settingsdefaultProvideror first available peragentConfigorder, validates availability, and updates label/button textChatInterfaceto stop passing removed props toCreateChatModalMultiAgentDropdownto useagentConfigorder (removes custom sort)Written by Cursor Bugbot for commit 2797ab3. This will update automatically on new commits. Configure here.