Skip to content

Conversation

@NoumanAMalik
Copy link

In the Settings modal, under Interface, at the bottom, added a new field to add a custom.
image

Whatever is added in this input, gets appended at the beginning of the default font families that were already defined from before. In the TerminalSessionManager.ts, I also added an event listener to automatically refresh the terminal whenever the font is changed, so the user sees it update right away.

@vercel
Copy link

vercel bot commented Jan 21, 2026

@NoumanAMalik is attempting to deploy a commit to the General Action Team on Vercel.

A member of the Team first needs to authorize it.

@rabanspiegel
Copy link
Contributor

thank you ! will review

@rabanspiegel
Copy link
Contributor

Great idea @NoumanAMalik.

A couple thoughts, it'd be great to have some save indicator or knowing whether the font has been set.

Two other fixes needed before merg:

  • TerminalSessionManager.applyTheme will overwrite the user’s custom fontFamily whenever theme updates run (theme overrides can include a font). Please make the user setting take precedence (e.g., skip applying theme font if a custom font is set, or reapply the custom font after applyTheme).
  • When the initial async getSettings() resolves, we set fontFamily but don’t call fitAddon.fit(), so the terminal can be mis‑sized until a resize. Please run fitAddon.fit() after applying the initial settings.

Let me know if you want to take another stab or whether I should finish it 🙏

@NoumanAMalik
Copy link
Author

bet, I'll get to it and make another commit EOD

@NoumanAMalik
Copy link
Author

When typing inside the text input field, there is a clear button as well as an keyboard shortcut badge showing the user to click enter to save.
When the save is succesful of the font family, a check mark will be shown to the user.

demo.-.save.indicator.mov

For the 2 bugs:

  1. When TerminalSessionManager.applyTheme rules, after the font family is set, we reapply the custom font after applyTheme sets the font.
  2. if the terminal is open, we run fitAddon.fit()

@rabanspiegel if you see any other issues, I'd be glad to address them.

@rabanspiegel
Copy link
Contributor

Thank you, will review by EOD!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants