changed to use secure operations to restrict operations #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clackner-gpa
requested changes
Jan 16, 2026
| await tableOperations.DeleteRecordAsync(record, cancellationToken); | ||
| SecureTableOperations<T> tableOperations = new(connection); | ||
| object primaryKey = tableOperations.BaseOperations.GetPrimaryKeys(record).First(); | ||
| await tableOperations.DeleteRecordWhereAsync(HttpContext.User, $"{PrimaryKeyField} = {{0}}", cancellationToken, primaryKey); |
Contributor
There was a problem hiding this comment.
Why are we changing this call?
Shouldn't we use
await tableOperations.DeleteRecordAsync(HttpContext.User, record, cancellationToken);
| SecureTableOperations<T> tableOperations = new(connection); | ||
|
|
||
| T? result = tableOperations.NewRecord(); | ||
| T? result = tableOperations.BaseOperations.NewRecord(); |
Contributor
There was a problem hiding this comment.
for cleaner operation let's add NewRecord to SecureTableOperations
| TableOperations<T> tableOperations = new(connection); | ||
| string tableName = tableOperations.TableName; | ||
| SecureTableOperations<T> tableOperations = new(connection); | ||
| string tableName = tableOperations.BaseOperations.TableName; |
Contributor
There was a problem hiding this comment.
Suggested change
| string tableName = tableOperations.BaseOperations.TableName; | |
| string tableName = tableOperations.TableName; |
Let's handle this in SecureTableOperations There are ways to have optional parameters in an interface definition., That would allow SecureTableOeprationsto beITableOperations` which I think makes this cleaner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements claim checking as an additional security measure to filter data through a tableoperations wrapper in model controllers.
JIRA Ticket(s)
Additional Support for: DIG-21
Ticket: DIG-22
Required PRs