Pattern support in header configuration #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 2, 2013 10:05
- Pattern is an optional field for a new header. If it's not set then the header will be sent for every request - Pattern is checked as a regular expression with the request url. It automatically adds .* before and after the configured pattern, so you can configure a string that if contained in the url will make it include the header. Configuration example: pattern=example.com -> header set for requests like http://example.com and http://www.example.com, not sent for http://lamboratory.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First: good job with the addon, very useful :)
I've added a new feature we needed to modify headers in a fork I created. It allows a new configuration parameter for each header, and only if the pattern matches the url it will apply the header change.
The commit includes a couple of commits with the following changes:
Regards,
Jorge