Add tool for testing of reference configuration files #1
Conversation
|
@orelgueta - I think it would be good if you browse through the two test scripts in src/simulation_model to make sure that the testing of the nominal prod5/prod6 model is reasonable. I don't think we want to enforce the strict coding / reviewing rules of simtools to the scripts here. |
There was a problem hiding this comment.
Copilot reviewed 6 out of 9 changed files in this pull request and generated 4 comments.
Files not reviewed (3)
- src/simulation_model/cfg/CTA-PROD5-Paranal-Alpha.cfg: Language not supported
- src/simulation_model/cfg/array_trigger_prod5_paranal_alpha.dat: Language not supported
- .github/workflows/CI-linter.yml: Evaluated as low risk
Comments suppressed due to low confidence (6)
src/simulation_model/download_configuration_from_zenodo.py:33
- The comment is unclear. Suggestion: 'Suppress RuntimeWarning; this warning is expected to be resolved in Python 3.12.'
warnings; should go away with python 3.12
src/simulation_model/test_reference_simtel_configuration.py:235
- Mismatch in the number of telescopes between sim_telarray and simtools configuration files.
raise ValueError("Number of telescopes in sim_telarray and simtools configuration files do not match.")
src/simulation_model/test_reference_simtel_configuration.py:256
- Replace print statements with logger.error or logger.info as appropriate.
print("Lines differ:")
src/simulation_model/test_reference_simtel_configuration.py:257
- Replace print statements with logger.error or logger.info as appropriate.
print("\t SIMTEL :", simtel_line)
src/simulation_model/test_reference_simtel_configuration.py:5
- Correct the spacing around the slash.
simtools-derived model parameters / configuration files using the simulation model database with those obtained using sim_telarray.
src/simulation_model/test_data_tables.py:51
- [nitpick] The error message 'Files {file} and {simtel_path} differ' is not very specific. Consider including the line numbers where the files differ.
logger.error(f"Files {file} and {simtel_path} differ")
| if simtel_line != simtools_line: | ||
| print("Lines differ:") | ||
| print("\t SIMTEL :", simtel_line) | ||
| print("\t SIMTOOLS:", simtools_line) |
There was a problem hiding this comment.
Replace print statements with logger.error or logger.info as appropriate.
| print("\t SIMTOOLS:", simtools_line) | |
| logger.error('Lines differ:\n\t SIMTEL : %s\n\t SIMTOOLS: %s', simtel_line, simtools_line) |
| simtel_par = [line for line in simtel_cfg if par.upper() in line.upper()] | ||
| simtools_par = [line for line in simtools_cfg if par.upper() in line.upper()] | ||
| if simtel_par != simtools_par: | ||
| print("Site parameter differ:") |
There was a problem hiding this comment.
Replace print statements with logger.error or logger.info as appropriate.
| print("Site parameter differ:") | |
| logger.error('Lines differ:') |
| simtools_par = [line for line in simtools_cfg if par.upper() in line.upper()] | ||
| if simtel_par != simtools_par: | ||
| print("Site parameter differ:") | ||
| print("\t SIMTEL :", simtel_par) |
There was a problem hiding this comment.
Replace print statements with logger.error or logger.info as appropriate.
| print("\t SIMTEL :", simtel_par) | |
| logger.error('Site parameter differ:') |
| if simtel_par != simtools_par: | ||
| print("Site parameter differ:") | ||
| print("\t SIMTEL :", simtel_par) | ||
| print("\t SIMTOOLS:", simtools_par) |
There was a problem hiding this comment.
Replace print statements with logger.error or logger.info as appropriate.
| print("\t SIMTOOLS:", simtools_par) | |
| logger.error('Site parameter differ:') |
orelgueta
left a comment
orelgueta
left a comment
There was a problem hiding this comment.
Did not do a thorough review, but it all looks good. Thanks!
Allow to test reference configuration files for prod5/prod6 against the original sim_telarray
configuration files.
Uses prod5/prod6 configurations uploaded to Zenodo (plus to files related to prod5-Alpha, which unfortunately are not part of the Zenodo archive)