Skip to content

Conversation

@s3cur3
Copy link
Contributor

@s3cur3 s3cur3 commented Dec 16, 2025

This allows a custom timeout for the visit action in particular, with the global timeout as the default.

This allows a custom timeout for the `visit` action in particular, with the global timeout as the default.
@s3cur3 s3cur3 mentioned this pull request Dec 16, 2025
retry(fun, remaining - @retry_interval)
end

@doc false
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add docs and import in Case.

@ftes
Copy link
Owner

ftes commented Dec 17, 2025

Thanks Tyler 🎈

I should probably look into adding timeout option to all Playwright functions.
This will require some changes to phoenix_test in cases where an opts variant already exists that restricts the allowed keys.

Example: https://github.com/germsvel/phoenix_test/blob/3a7fa842c07e0f3bae3fc743c1e20f80ff0e1fdb/lib/phoenix_test.ex#L592

@ftes ftes merged commit 7073add into ftes:main Dec 17, 2025
1 check passed
@s3cur3
Copy link
Contributor Author

s3cur3 commented Dec 17, 2025

Ooh, interesting... yeah, that's tricky. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants