Skip to content

Revert string renames #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wallymathieu merged 1 commit into from
Jan 11, 2026
Merged

Revert string renames #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<PackageIcon>logo.png</PackageIcon>
<PackageReadmeFile>README.md</PackageReadmeFile>
<PackageTags>f# FSharp Applicative Monad MonadTransformer Arrow Overloading</PackageTags>
<VersionPrefix>1.9.0</VersionPrefix>
<VersionPrefix>1.9.1</VersionPrefix>
<VersionSuffix></VersionSuffix>
<Version Condition=" '$(VersionSuffix)' != '' ">$(VersionPrefix)-$(VersionSuffix)</Version>
<Version Condition=" '$(VersionSuffix)' == '' ">$(VersionPrefix)</Version>
Expand Down
3 changes: 2 additions & 1 deletion RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#### 1.9.0 - January 11 2026
#### 1.9.1 - January 11 2026

- Task related function fixes and improvements
- Enable try blocks for ValueTask
- Add Obj module
Expand Down
30 changes: 15 additions & 15 deletions RELEASE_NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
Release Notes for FSharpPlus 1.9.0 - January 11 2026
Release Notes for FSharpPlus 1.9.1 - January 11 2026
-----------------------------------------------------

Task related function fixes and improvements
Enable try blocks for ValueTask
Add Obj module
Add some error handling functions for Tasks
Add ignore to some common type extensions
Add bindTask and bindInto to Result
Add missing (.>) and (<.) zip-applicative operators
Add Active Pattern for CI strings and AggregateException
Rename non-sequential applicative CEs to zapp
Fix compilation for Fable 4.27
Fix several functions in ResizeArray
Fix Seq.lift3
Fix some XML comments
Drop target framework version net45
- Task related function fixes and improvements
- Enable try blocks for ValueTask
- Add Obj module
- Add some error handling functions for Tasks
- Add ignore to some common type extensions
- Add bindTask and bindInto to Result
- Add missing (.>) and (<.) zip-applicative operators
- Add Active Pattern for CI strings and AggregateException
- Rename non-sequential applicative CEs to zapp
- Fix compilation for Fable 4.27
- Fix several functions in ResizeArray
- Fix Seq.lift3
- Fix some XML comments
- Drop target framework version net45
4 changes: 2 additions & 2 deletions src/FSharpPlus/Extensions/String.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ module String =
///
/// Note this is distinct from trim which trims the given characters,
/// not white spaces.
let trim (source: string) =
let trimWhiteSpaces (source: string) =
let source = nullArgCheck (nameof source) source

source.Trim ()
Expand Down Expand Up @@ -154,7 +154,7 @@ module String =
source.PadRight (totalLength, paddingChar)

/// Removes all leading and trailing occurrences of specified characters from the given string.
let trimBoth (trimChars: char seq) (source: string) =
let trim (trimChars: char seq) (source: string) =
let source = nullArgCheck (nameof source) source

source.Trim (Seq.toArray trimChars)
Expand Down
Loading