Update Dockerfile.windows #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing from server core to nano - this speeds up build, run and download times.
friism
force-pushed
the
master
branch
2 times, most recently
from
cd43a91 to
414b4cd
Compare
dermeister0
reviewed
Jan 24, 2017
| environment: | ||
| sa_password: "Password1" | ||
| ports: | ||
| - "1433:1433" # for debug. Remove this for production |
There was a problem hiding this comment.
How does it help to debug? You can't connect to the port from the host machine.
Owner
There was a problem hiding this comment.
@dermeister0 yeah you can - depending on the configuration, it's available on either the IP address of the container or the host.
There was a problem hiding this comment.
The DB is available on the container IP even if the 'ports' directive is missing.
If port mapping is used, you can connect to the host from other machine, but not from localhost.
https://blogs.technet.microsoft.com/virtualization/2016/05/25/windows-nat-winnat-capabilities-and-limitations/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing from server core to nano - this speeds up build, run and download times.