Skip to content

Conversation

@namrata111f
Copy link
Contributor

Adding changes to make react config configurable by user.
Have tested with 1) the property enabled and 2) not set:

455   4 (Low)        eslint:react/jsx-newline                     utils.js:219:17                                JSX element should start in a new line
  456   4 (Low)        eslint:react/jsx-one-expression-per-line     utils.js:219:20                                `Monthly Payment: ` must be placed on a new line
  457   4 (Low)        eslint:react/jsx-no-literals                 utils.js:219:20                                Missing JSX expression container around literal string: "Monthly Payment:"
  458   4 (Low)        eslint:react/jsx-one-expression-per-line     utils.js:219:37                                `PriceDisplay` must be placed on a new line
  459   4 (Low)        eslint:react/jsx-max-props-per-line          utils.js:219:75                                Prop `showCents` must be placed on a new line



=== Summary

Found 459 violation(s) across 8 file(s):
    30 High severity violation(s) found.
    241 Moderate severity violation(s) found.
    188 Low severity violation(s) found.

Tested with the config value disabled for react (JavaScript rules ran as expected):

  173   3 (Moderate)   eslint:one-var                          utils.js:236:8                                 Combine this with the previous 'const' statement.
  174   3 (Moderate)   eslint:sort-keys                        utils.js:238:5                                 Expected object keys to be in ascending order. 'maxPrice' should be before 'minPrice'.
  175   3 (Moderate)   eslint:one-var                          utils.js:243:8                                 Combine this with the previous 'const' statement.
  176   3 (Moderate)   eslint:sort-keys                        utils.js:245:5                                 Expected object keys to be in ascending order. 'BROKERS' should be before 'PROPERTIES'.



=== Summary

Found 176 violation(s) across 8 file(s):
    12 High severity violation(s) found.
    164 Moderate severity violation(s) found.

@namrata111f namrata111f merged commit 20abe29 into dev Jan 29, 2026
7 checks passed
@namrata111f namrata111f deleted the ng-add-react-config branch January 29, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants