Skip to content

Potential issue in equivalent buoyancy formulation of the ThermalSWSolver class #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nhartney wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Potential issue in equivalent buoyancy formulation of the ThermalSWSolver class #646

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b1b3c8
potential issue in equivalent buoyancy formulation of the thermal SW …
nhartney Aug 7, 2025
6f9a70e
Merge remote-tracking branch 'origin/main' into investigate_equib_buo…
tommbendall Jan 7, 2026
bdd0dc8
Merge branch 'main' into investigate_equib_buoyancy_solver
jshipton Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions gusto/equations/shallow_water_equations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,6 +566,10 @@ def schur_complement_form(self, alpha=0.5, tau_values=None):
# bbar was be_bar and here we correct to become bbar
bref += self.parameters.beta2 * self.qvbar

# however, we leave b_ as is, and do not add a contribution from qv.
# It already represents the perturbation to b_e, and since we
# neglect perturbations to qv, the equation below is already correct

seqn = (
inner(w_, (u_)) * dx
- beta_u * (D_) * div(w_*bref) * dx
Expand Down