EnsembleBlockDiagonalMat and EnsembleBJacobiPC
#4711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct/firedrake into JHopeCollins/ensemble-mat
JHopeCollins
commented
Nov 20, 2025
connorjward
requested changes
Dec 1, 2025
connorjward
requested changes
Dec 2, 2025
connorjward
reviewed
Dec 2, 2025
dham
previously requested changes
Dec 2, 2025
Member
dham
left a comment
dham
left a comment
There was a problem hiding this comment.
Once the names and error checking is done this is good to go.
JHopeCollins
commented
Dec 2, 2025
connorjward
previously approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A python
Matand pythonPCfor block-diagonal systems over anEnsembleFunctionSpace, with each block corresponding to one component of theEnsembleFunctionSpace.The
EnsembleBlockDiagonalMatdoes not have to be square, but theEnsembleBlockDiagonalPCwill obviously only work if it is square.