-
Notifications
You must be signed in to change notification settings - Fork 177
Dual interpolation from/into MixedFunctionSpace #4197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
924c9af to
2e34465
Compare
Member
|
I suspect this change has a risk of breaking the adjoint. Can we also please have an adjoint test for this? |
f566861 to
0d5a629
Compare
pbrubeck
commented
Apr 7, 2025
bb02501 to
a8d23de
Compare
pbrubeck
commented
Apr 15, 2025
dham
reviewed
Apr 30, 2025
dham
approved these changes
May 7, 2025
dham
previously approved these changes
May 7, 2025
pbrubeck
commented
May 7, 2025
Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>
dham
approved these changes
May 7, 2025
indiamai
pushed a commit
that referenced
this pull request
May 13, 2025
* Interpolation onto subfunctions * More generic approach using fieldsplit * Interpolate: Fix parloop args ordering * Fix dual * Interpolate from MixedFunctionSpace * Test Interpolate from vector/mixed to mixed * Interpolate from (scalar/mixed) to (scalar/mixed) Co-authored-by: Pablo Brubeck <brubeck@protonmail.com> --------- Co-authored-by: David A. Ham <david.ham@imperial.ac.uk>
colinjcotter
pushed a commit
that referenced
this pull request
May 14, 2025
* Interpolation onto subfunctions * More generic approach using fieldsplit * Interpolate: Fix parloop args ordering * Fix dual * Interpolate from MixedFunctionSpace * Test Interpolate from vector/mixed to mixed * Interpolate from (scalar/mixed) to (scalar/mixed) Co-authored-by: Pablo Brubeck <brubeck@protonmail.com> --------- Co-authored-by: David A. Ham <david.ham@imperial.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables interpolation of a
BaseFormonto a sub-Cofunctiondefined via indexedArguments.The indirection is handled symbolically within
assemble, so thatbecomes
Depends on FEniCS/ufl#370