-
Notifications
You must be signed in to change notification settings - Fork 177
Updates for latest release of PETSc #4181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What's the long term plan in terms of CI? My guess is that you may want to have three CIs:
Feel free to move this elsewhere if more appropriate. Note that the last two CIs will need |
I don't know if this is a goal here. I think we have two Firedrake configurations which we want to test:
I think the idea is to track and advance (weekly-ish) a known "last good commit" on PETSc |
My rationale for saying this was: say that you are forced to release a firedrake 2025.4.1 in July. Maybe at that point, since you were forced to do a new release anyways, you would want to move to PETSc 3.23.2 (or whatever point version they have arrived at), rather than stick to the 3.23.0 as of March. |
I'm not sure that we necessarily want to always track the different releases. It introduces a source of instability (though likely very minor) into our own releases. If things work as they are I'm not sure that we should take any unnecessary risks. |
rckirby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, let's land after #4121.
Supersedes #3997
Closes #4155
Should follow #4135 (merged)
Note that we expect the docs build to fail because that is using an older PETSc version.