RestrictedFunctionSpace: support Fieldsplit, multigrid, and python PC #4169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
force-pushed
the
pbrubeck/fix/restricted-dmhooks
branch
from
4193431 to
1b20212
Compare
pbrubeck
commented
Mar 31, 2025
pbrubeck
commented
Mar 31, 2025
pbrubeck
changed the title
ksagiyam
requested changes
Mar 31, 2025
pbrubeck
force-pushed
the
pbrubeck/fix/restricted-dmhooks
branch
from
9df7a04 to
7a07dff
Compare
pbrubeck
force-pushed
the
pbrubeck/fix/restricted-dmhooks
branch
from
9a449c5 to
f165b4b
Compare
pbrubeck
commented
Mar 31, 2025
pbrubeck
commented
Apr 1, 2025
connorjward
requested changes
Apr 9, 2025
pbrubeck
commented
Apr 9, 2025
…eproject/firedrake into pbrubeck/fix/restricted-dmhooks
pbrubeck
commented
Aug 8, 2025
rckirby
reviewed
Aug 8, 2025
Contributor
rckirby
left a comment
rckirby
left a comment
There was a problem hiding this comment.
Question: There are similar (I think) issues if we try to use Firedrake preconditioners inside of the reduced space snes VI solvers. Is there any way to connect some of this work to that case? (Of course, the information about restriction is coming from inside a SNES instead of outside in Firedrake in that case).
ksagiyam
requested changes
Aug 15, 2025
pbrubeck
commented
Aug 19, 2025
connorjward
previously requested changes
Aug 20, 2025
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Please split some of this out into another PR. And @ksagiyam can review
pbrubeck
commented
Aug 21, 2025
ksagiyam
previously requested changes
Aug 29, 2025
pbrubeck
commented
Aug 29, 2025
ksagiyam
reviewed
Aug 29, 2025
pbrubeck
force-pushed
the
pbrubeck/fix/restricted-dmhooks
branch
from
4a1d57d to
ddc189a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for pc_type
fieldsplit,mg, andpythonwithRestrictedFunctionSpace.Apparently setting name of the RFS also changes the name of the split in the PETSc solver option.
With the default name, the options prefix becomes
fieldsplit_Restricted_on_boundary, instead offieldsplit_x.This PR ensures that the restricted spaces that are created within solvers preserve the name of the unrestricted parent space so that the same set of fieldsplit options works for both
restrict=Falseandrestrict=True.