Skip to content

Conversation

@pbrubeck
Copy link
Contributor

@pbrubeck pbrubeck commented Jan 14, 2025

Description

This PR adds support for Boundary Quadrature / BQ elements.

On triangles and tetrahedra, Quadrature elements do not represent polynomial spaces, as the number of quadrature points differs from the dimension of P_k. Therefore the degree of a Quadrature element is used as the degree of the integrand to be integrated exactly. On tensor product cells, the Quadrature element corresponds to the GL element, but the degrees will not match.

Whenever assembling forms with Quadrature or Boundary Quadrature elements, we use a quadrature matching the element degree, as opposed to the estimated quadrature degree.

We also add support for projection onto the BQ space using the same trace norm on the facets used by HDiv Trace. This facilitates computing the FacetNormal at quadrature points:

project(FacetNormal(mesh), VectorFunctionSpace(mesh, "BQ", degree))

Depends on firedrakeproject/fiat#126

@github-actions
Copy link

github-actions bot commented Jan 14, 2025

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8197 ran7484 passed713 skipped0 failed

@github-actions
Copy link

github-actions bot commented Jan 14, 2025

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8244 ran6600 passed1644 skipped0 failed

@github-actions
Copy link

github-actions bot commented Mar 13, 2025

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake default8285 ran7583 passed702 skipped0 failed

@pbrubeck pbrubeck changed the title DO NOT MERGE Boundary Quadrature elements Mar 17, 2025
@pbrubeck pbrubeck marked this pull request as ready for review March 17, 2025 12:15
@pbrubeck pbrubeck changed the base branch from master to pbrubeck/gem/simplify-indexed March 17, 2025 21:56
@pbrubeck pbrubeck force-pushed the pbrubeck/finat-boundary-quadrature branch from d45c40f to 16eec72 Compare March 18, 2025 11:37
@pbrubeck pbrubeck changed the base branch from pbrubeck/gem/simplify-indexed to master March 18, 2025 15:11
@pbrubeck pbrubeck enabled auto-merge (squash) March 28, 2025 14:00
@pbrubeck pbrubeck merged commit c1d8a15 into master Mar 28, 2025
13 checks passed
@pbrubeck pbrubeck deleted the pbrubeck/finat-boundary-quadrature branch March 28, 2025 14:21
@ksagiyam
Copy link
Contributor

Reviewed during the meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants