Skip to content

Gem tabulation #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pbrubeck wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Gem tabulation #172

pbrubeck wants to merge 33 commits into from

Conversation

@pbrubeck
Copy link

@pbrubeck pbrubeck commented Aug 20, 2025 •
edited
Loading

Tabulate unknown points directly to gem, as opposed to first tabulating to sympy.

The gem-only approach is significantly faster:

pytest test/FIAT/unit/test_macro.py -k sympy
=============================== 6 passed, 233 deselected in 14.77s ===============================

pytest test/FIAT/unit/test_macro.py -k gem
=============================== 6 passed, 233 deselected in 1.31s ================================

@pbrubeck pbrubeck force-pushed the pbrubeck/gem-tabulation branch from 1bc0aef to 2f7fb1c Compare August 20, 2025 22:07
@pbrubeck pbrubeck force-pushed the pbrubeck/gem-tabulation branch from f95d2a4 to 2c54e72 Compare August 21, 2025 09:25
@pbrubeck pbrubeck force-pushed the pbrubeck/gem-tabulation branch from 8e60163 to 26113d8 Compare August 21, 2025 12:33
@pbrubeck pbrubeck force-pushed the pbrubeck/gem-tabulation branch from cce6efc to fdefbbd Compare August 21, 2025 15:32
@pbrubeck pbrubeck force-pushed the pbrubeck/gem-tabulation branch from ec7e65c to 6868df5 Compare August 22, 2025 14:38
@pbrubeck pbrubeck mentioned this pull request Aug 26, 2025
Draft
@pbrubeck pbrubeck force-pushed the pbrubeck/gem-tabulation branch from e03a7a7 to 572af82 Compare August 26, 2025 16:48
@pbrubeck pbrubeck mentioned this pull request Aug 26, 2025
Closed
rckirby
rckirby requested changes Aug 26, 2025
View reviewed changes
Copy link

@rckirby rckirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the speedup and reduced dependency on sympy. I have a few questions

@pbrubeck pbrubeck force-pushed the pbrubeck/gem-tabulation branch from 41a0a71 to 0799365 Compare August 27, 2025 16:44
@pbrubeck pbrubeck force-pushed the pbrubeck/gem-tabulation branch from 0799365 to 3225043 Compare August 27, 2025 22:00
@pbrubeck pbrubeck force-pushed the pbrubeck/gem-tabulation branch from e3a2eef to 4d00815 Compare August 28, 2025 15:09
pbrubeck
pbrubeck commented Aug 28, 2025
View reviewed changes
@pbrubeck pbrubeck force-pushed the pbrubeck/gem-tabulation branch from fd3053f to 1927f47 Compare August 28, 2025 20:58
@pbrubeck pbrubeck force-pushed the pbrubeck/gem-tabulation branch from 1927f47 to 1044442 Compare August 28, 2025 20:59
@rckirby rckirby self-requested a review August 28, 2025 21:05
rckirby
rckirby approved these changes Aug 28, 2025
View reviewed changes
Copy link

@rckirby rckirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my concerns are addressed now.

pbrubeck
pbrubeck commented Oct 18, 2025
View reviewed changes
pbrubeck
pbrubeck commented Oct 18, 2025
View reviewed changes
pbrubeck
pbrubeck commented Oct 18, 2025
View reviewed changes
@pbrubeck pbrubeck force-pushed the pbrubeck/gem-tabulation branch from e4b1ce9 to 2b5eb2a Compare October 23, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rckirby rckirby rckirby approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pbrubeck @rckirby