Skip to content

Conversation

@JHopeCollins
Copy link
Member

@JHopeCollins JHopeCollins commented Jul 2, 2025

This fixes errors and warnings so asQ works with the latest firedrake release.
Once this is merged we can make a tagged asQ release so we're then free to develop on asQ/master using firedrake/master.

  1. Update the github workflow for the pip install and release changes.
  2. Fix for petsc changing default return val for an empty prefix.
  3. Warning fix for FunctionSpace.subfunctions -> subspaces.
  4. Warning fix for passing quadrature_degree to project.

@JHopeCollins JHopeCollins self-assigned this Jul 2, 2025
@JHopeCollins JHopeCollins added the upstream Issue related to upstream dependencies label Jul 2, 2025
@JHopeCollins JHopeCollins marked this pull request as ready for review July 2, 2025 12:45
@JHopeCollins JHopeCollins requested a review from colinjcotter July 2, 2025 12:45
@JHopeCollins
Copy link
Member Author

There is one test that is failing by hanging and timing out (the Nitsche time-dependent bcs test), but I can't replicate it locally. This isn't new, we think it's related to the ensemble compiling the same form simultaneously on different members, but have never found the root cause for certain, or a reliable fix yet.

For now I think we should merge this as the failure is unrelated to the updates, and is rarely seen locally.

Copy link
Collaborator

@colinjcotter colinjcotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go.
Let's keep an eye on that timing out test though.

@JHopeCollins JHopeCollins merged commit 8b4aeb8 into master Jul 3, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream Issue related to upstream dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants