fix(js/plugins/googleai,vertexai): support thoughtSignature in fromGeminiPart #3921
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3920
Problem
When using the Gemini 3 Pro model (e.g.,
gemini-3-pro-preview) which enables thinking by default, the API returns response parts containing athoughtSignatureproperty. The current fromGeminiPart implementation in bothgoogleaiandvertexaiplugins throws anUnsupported GeminiPart typeerror because it does not recognize parts that containthoughtSignaturewithout thethoughtproperty.Solution
This PR updates the fromGeminiPart logic in both plugins to correctly identify and handle
thoughtSignatureparts by checking for both'thought' in partand'thoughtSignature' in part. This allows these parts to be processed by the existing fromThought / fromGeminiThought functions, which already support thethoughtSignatureproperty.Checklist:
gemini-3-pro-preview- error resolved, responses withthoughtSignaturenow parse correctly)