Fix sonarqube analysis #96
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| -Dsonar.test.inclusions=**/*_test.cpp,**/test_*.cpp,tests/**/*.cpp \ | ||
| -Dsonar.exclusions=**/OgreXML/**,**/dependencies/**,**/*_autogen/**,**/CMakeFiles/**,**/ui_files/**,**/moc_*,**/_deps/** \ | ||
| -Dsonar.coverage.exclusions=**/*_test.cpp,**/test_*.cpp,tests/**/*.cpp,tests/**/*.qml,**/*_autogen/** \ | ||
| -Dsonar.c.file.suffixes=- \ | ||
| -Dsonar.cpp.file.suffixes=- \ | ||
| -Dsonar.objc.file.suffixes=- \ | ||
| -Dsonar.c.file.suffixes=.c \ | ||
| -Dsonar.cpp.file.suffixes=.cpp,.cc,.cxx,.c++,.hpp,.hh,.hxx,.h++ \ | ||
| -Dsonar.objc.file.suffixes=.m,.mm \ | ||
| -Dsonar.verbose=true" | ||
| # Add build-wrapper output if it exists | ||
| if [ -d "$BUILD_WRAPPER_OUTPUT" ] && [ -f "$BUILD_WRAPPER_OUTPUT/build-wrapper-output.json" ]; then | ||
| echo "Adding build-wrapper output to analysis" | ||
| SCANNER_CMD="$SCANNER_CMD -Dsonar.cfamily.build-wrapper-output=$BUILD_WRAPPER_OUTPUT" |
There was a problem hiding this comment.
The build-wrapper step earlier in this workflow runs with --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} where the env var is ./, so the wrapper writes its build-wrapper-dump.json directly under the repository root. The new analysis step hardcodes BUILD_WRAPPER_OUTPUT="${{ env.BUILD_WRAPPER_OUT_DIR }}bw-output" and checks for build-wrapper-output.json. Neither the directory nor the file name matches what the wrapper actually produces (build-wrapper-dump.json in ./). As a result the script always skips adding -Dsonar.cfamily.build-wrapper-output, causing SonarCloud’s C/C++ analysis to run without the required compilation database and the scan will fail or be ineffective. The detection should align with the actual output path/name used when running the wrapper.
Useful? React with 👍 / 👎.
Summary
Technical Details
✨ Features
🐛 Bugfixes