Skip to content

Conversation

@fernandotonon
Copy link
Owner

Summary

Technical Details

✨ Features

πŸ› Bugfixes

@fernandotonon fernandotonon merged commit 41171cc into master Nov 11, 2025
5 checks passed
@fernandotonon fernandotonon deleted the fix-sonar branch November 11, 2025 05:53
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +854 to +857
BUILD_WRAPPER_OUTPUT="${{ env.BUILD_WRAPPER_OUT_DIR }}bw-output"
if [ -d "$BUILD_WRAPPER_OUTPUT" ] && [ -f "$BUILD_WRAPPER_OUTPUT/build-wrapper-output.json" ]; then
echo "Build-wrapper output found at: $BUILD_WRAPPER_OUTPUT"
ls -la "$BUILD_WRAPPER_OUTPUT" | head -5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fix build-wrapper path detection for SonarCloud step

The new SonarCloud logic sets BUILD_WRAPPER_OUTPUT="${{ env.BUILD_WRAPPER_OUT_DIR }}bw-output" and looks for build-wrapper-output.json, but the earlier build-wrapper invocation uses --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} (which is ./) and produces build-wrapper-dump.json directly in the repository root. Because no bw-output directory or build-wrapper-output.json file is created, this condition always fails and sonar.cfamily.build-wrapper-output is never passed to sonar-scanner, even though C/C++ analysis has been re-enabled. The scan will still error out or skip C++ files. Point the check (and subsequent parameter) at the actual output directory/file or adjust the build-wrapper invocation to write to the expected location.

Useful? React with πŸ‘Β / πŸ‘Ž.

@fernandotonon fernandotonon restored the fix-sonar branch November 12, 2025 06:03
@fernandotonon fernandotonon deleted the fix-sonar branch November 12, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants