Skip to content

Conversation

@mavit
Copy link
Contributor

@mavit mavit commented Oct 29, 2025

I tried to follow the instructions at https://anitya.readthedocs.io/en/latest/contributing.html#docker-podman but couldn't get it working, so these changes are untested.

@mavit mavit requested a review from a team as a code owner October 29, 2025 14:42
@softwarefactory-project-zuul
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/1332e985b45a46bcb267b0907e38cd22

✔️ fi-tox-mypy SUCCESS in 5m 10s
✔️ fi-tox-lint SUCCESS in 5m 15s
✔️ fi-tox-format SUCCESS in 5m 14s
fi-tox-python310 FAILURE in 8m 06s
fi-tox-python311 FAILURE in 8m 35s
fi-tox-python312 FAILURE in 8m 45s
✔️ fi-tox-docs SUCCESS in 5m 20s
✔️ fi-tox-bandit SUCCESS in 5m 16s
fi-tox-diff-cover FAILURE in 9m 24s

@Zlopez
Copy link
Contributor

Zlopez commented Oct 30, 2025

I tried to follow the instructions at https://anitya.readthedocs.io/en/latest/contributing.html#docker-podman but couldn't get it working, so these changes are untested.

What issue did you hit? Also you should be able to just run tox tests without the need to run the docker environment.

Copy link
Contributor

@Zlopez Zlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't rename backend as it will cause a mess in the database.

"""

name = "Gitea"
name = "Gitea/Forgejo"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a good idea, as it will invalidate the projects that are already have Gitea set as backend and they will not recognize the backend.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into doing something like the following instead:

<select id="backend" name="backend" required="" tabindex="3">
...
  <option value="Gitea">Gitea/Forgejo</option>
...
</select>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing that in HTML should be OK

@mavit mavit marked this pull request as draft October 30, 2025 14:24
@Zlopez Zlopez mentioned this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants