-
Notifications
You must be signed in to change notification settings - Fork 118
Make it more obvious to use the Gitea backend for Forgejo/Codeberg #1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci ✔️ fi-tox-mypy SUCCESS in 5m 10s |
What issue did you hit? Also you should be able to just run tox tests without the need to run the docker environment. |
Zlopez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't rename backend as it will cause a mess in the database.
| """ | ||
|
|
||
| name = "Gitea" | ||
| name = "Gitea/Forgejo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a good idea, as it will invalidate the projects that are already have Gitea set as backend and they will not recognize the backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into doing something like the following instead:
<select id="backend" name="backend" required="" tabindex="3">
...
<option value="Gitea">Gitea/Forgejo</option>
...
</select>There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing that in HTML should be OK
I tried to follow the instructions at https://anitya.readthedocs.io/en/latest/contributing.html#docker-podman but couldn't get it working, so these changes are untested.