Skip to content

fix(libsinsp): Force CLONE_FILES for threads with missing flag from driver #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fremmi wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix(libsinsp): Force CLONE_FILES for threads with missing flag from driver #2715

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcdb0f3
fix(libsinsp): Force CLONE_FILES for threads with missing flag from d…
fremmi Nov 11, 2025
7c80fc9
Update userspace/libsinsp/parsers.cpp
fremmi Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions userspace/libsinsp/parsers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,7 +1163,17 @@ void sinsp_parser::parse_clone_exit_child(sinsp_evt &evt, sinsp_parser_verdict &
*/
int64_t lookup_tid;

bool is_actually_new_process = (child_tinfo->m_pid == child_tinfo->m_tid);
bool is_thread_leader = !(child_tinfo->m_flags & PPM_CL_CLONE_THREAD);

if(is_thread_leader && !is_actually_new_process) {
/* When a thread is detected but missing the CLONE_FILES flag,
* force the flag to ensure proper FD table sharing between threads.
*/
is_thread_leader = false;
child_tinfo->m_flags |= PPM_CL_CLONE_THREAD;
}

if(is_thread_leader) {
/* We need to copy data from the parent */
lookup_tid = child_tinfo->m_ptid;
Expand Down
Loading