-
Notifications
You must be signed in to change notification settings - Fork 176
fix(sinsp): restore binary compatibility with pre-3.10 static plugins #2315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
API 3.10 changed the layout of the plugin_api struct in an ABI-incompatible way. This does not matter for shared library plugins, but statically linked plugins do depend on binary compatibility between the two structs. Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
Perf diff from master - unit testsHeap diff from master - unit testsHeap diff from master - scap fileBenchmarks diff from master |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2315 +/- ##
=======================================
Coverage 77.16% 77.16%
=======================================
Files 224 224
Lines 30135 30135
Branches 4605 4605
=======================================
Hits 23254 23254
Misses 6881 6881
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/milestone 0.41.0 |
|
@FedeDP: The provided milestone is not valid for this repository. Milestones in this repository: [ Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
FedeDP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, gnosek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 30c4cfec9327dccf7fa4127c3c8b7ffbaa78d727 |
|
Ops |
|
cc @FedeDP |
API 3.10 changed the layout of the plugin_api struct in an ABI-incompatible way. This does not matter for shared library plugins, but statically linked plugins do depend on binary compatibility between the two structs.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is a subset of #2278 that should IMO go in fairly soon (the rest can wait as we figure out the details).
Does this PR introduce a user-facing change?: