Skip to content

Conversation

@gnosek
Copy link
Contributor

@gnosek gnosek commented Mar 17, 2025

API 3.10 changed the layout of the plugin_api struct in an ABI-incompatible way. This does not matter for shared library plugins, but statically linked plugins do depend on binary compatibility between the two structs.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This is a subset of #2278 that should IMO go in fairly soon (the rest can wait as we figure out the details).

Does this PR introduce a user-facing change?:

NONE

API 3.10 changed the layout of the plugin_api struct
in an ABI-incompatible way. This does not matter for shared library
plugins, but statically linked plugins do depend on binary compatibility
between the two structs.

Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
@github-actions
Copy link

Perf diff from master - unit tests

     6.02%     -0.50%  [.] sinsp::next
     3.33%     +0.43%  [.] next_event_from_file
     1.97%     +0.39%  [.] sinsp_thread_manager::find_thread
     1.37%     -0.30%  [.] next
     1.04%     -0.24%  [.] sinsp::fetch_next_event
     0.89%     +0.19%  [.] libsinsp::sinsp_suppress::process_event
     1.86%     -0.17%  [.] sinsp_thread_manager::get_thread_ref
     0.87%     +0.16%  [.] sinsp_evt_filter::sinsp_evt_filter
     0.31%     -0.15%  [.] thread_group_info::get_first_thread
     5.49%     -0.15%  [.] sinsp_evt::get_type

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0440         +0.0441           142           148           142           148
BM_sinsp_split_median                                          +0.0534         +0.0534           142           149           142           149
BM_sinsp_split_stddev                                          +1.9079         +1.9077             1             4             1             4
BM_sinsp_split_cv                                              +1.7852         +1.7850             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0330         -0.0330            54            53            54            53
BM_sinsp_concatenate_paths_relative_path_median                -0.0344         -0.0344            54            53            54            53
BM_sinsp_concatenate_paths_relative_path_stddev                -0.4895         -0.4890             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.4720         -0.4716             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0156         -0.0156            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0145         -0.0145            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.3338         -0.3330             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.3233         -0.3224             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0365         -0.0365            53            51            53            51
BM_sinsp_concatenate_paths_absolute_path_median                -0.0285         -0.0285            52            51            52            51
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.7384         -0.7380             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.7285         -0.7281             0             0             0             0

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.16%. Comparing base (15c4369) to head (2a6eca1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2315   +/-   ##
=======================================
  Coverage   77.16%   77.16%           
=======================================
  Files         224      224           
  Lines       30135    30135           
  Branches     4605     4605           
=======================================
  Hits        23254    23254           
  Misses       6881     6881           
Flag Coverage Δ
libsinsp 77.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FedeDP
Copy link
Contributor

FedeDP commented Mar 17, 2025

/milestone 0.41.0

@poiana
Copy link
Contributor

poiana commented Mar 17, 2025

@FedeDP: The provided milestone is not valid for this repository. Milestones in this repository: [0.21.0, TBD, next-driver]

Use /milestone clear to clear the milestone.

Details

In response to this:

/milestone 0.41.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, gnosek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Mar 17, 2025

LGTM label has been added.

DetailsGit tree hash: 30c4cfec9327dccf7fa4127c3c8b7ffbaa78d727

@FedeDP
Copy link
Contributor

FedeDP commented Mar 17, 2025

Ops
/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Mar 17, 2025
@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Mar 17, 2025
@leogr
Copy link
Member

leogr commented Mar 17, 2025

cc @FedeDP

@poiana poiana merged commit d815a12 into falcosecurity:master Mar 17, 2025
47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Mar 17, 2025
@gnosek gnosek deleted the fix-static-plugins-3-10 branch March 18, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants