feat: handle exceptions and errors gracefully #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/bug
Signed-off-by: szucsitg <32290917+szucsitg@users.noreply.github.com>
szucsitg
force-pushed
the
feat-exception-handling
branch
from
ac895e4 to
ff29c1f
Compare
FedeDP
approved these changes
Sep 24, 2025
Collaborator
FedeDP
left a comment
FedeDP
left a comment
There was a problem hiding this comment.
Thanks for this!
Future improvements:
- use a global "constant" for the default timeout
- check that many files have their own
try exceptthat might be superseded by your patch
In any case, since this solves a real problem, it's time to merge this one!
Thank you very much!
/approve
Contributor
|
LGTM label has been added. DetailsGit tree hash: 170889cfba8678f050fe15837b2c48cfe90b83e0 |
Collaborator
|
@szucsitg i completely forgot; are you perhaps willing to step up as a repo maintainer? Please let me know and we can discuss it further! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind feature
Any specific area of the project related to this PR?
/area crawler
What this PR does / why we need it:
Currently the kernel update pipeline doesn't run due to transient network issues, and some decommissioned/terminated mirrors. This is an attempt to permanently fix all current and underlying issue with proper logging, by catching the exceptions during download.
Additionally it sets a timeout for not waiting excessively for non-functioning servers.
Added a new CLI flag to output JSON object from code to a file not from stdout, therefore error logs won't break the output. Updated params in
action.yamlto use it.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: