Skip to content

fix(Makefile): pass build args to push/{builder,latest} #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leogr merged 1 commit into from
Dec 10, 2025
Merged

fix(Makefile): pass build args to push/{builder,latest} #405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,19 +74,26 @@ push/all: push/builder push/driverkit

.PHONY: push/builder
push/builder:
$(foreach b,$(BUILDERS),\
$(DOCKER) buildx build --push -t "$(IMAGE_NAME_BUILDER_BASE):$b-$(GIT_REF)" -t "$(IMAGE_NAME_BUILDER_BASE):$b-$(GIT_COMMIT)" -f docker/builders/builder-$b.Dockerfile . ; \
)
@ for b in $(BUILDERS); do \
$(DOCKER) buildx build --push \
-t "$(IMAGE_NAME_BUILDER_BASE):$$b-$(GIT_REF)" \
-t "$(IMAGE_NAME_BUILDER_BASE):$$b-$(GIT_COMMIT)" \
-f docker/builders/builder-$$b.Dockerfile \
--build-arg CMAKE_VERSION=$(BUILDERS_CMAKE_VERSION) . ; \
done

.PHONY: push/driverkit
push/driverkit:
$(DOCKER) buildx build --push -t "$(IMAGE_NAME_DRIVERKIT_REF)" -t "$(IMAGE_NAME_DRIVERKIT_COMMIT)" -f docker/driverkit.Dockerfile .

.PHONY: push/latest
push/latest:
$(foreach b,$(BUILDERS),\
$(DOCKER) buildx build --push -t "$(IMAGE_NAME_BUILDER_BASE):$b-latest" -f docker/builders/builder-$b.Dockerfile . ; \
)
@ for b in $(BUILDERS); do \
$(DOCKER) buildx build --push \
-t "$(IMAGE_NAME_BUILDER_BASE):$$b-latest" \
-f docker/builders/builder-$$b.Dockerfile \
--build-arg CMAKE_VERSION=$(BUILDERS_CMAKE_VERSION) . ; \
done
$(DOCKER) buildx build --push -t "$(IMAGE_NAME_DRIVERKIT_LATEST)" -f docker/driverkit.Dockerfile .

manifest/all: manifest/driverkit
Expand Down
Loading