Fix dependent handling in OneHot transform #4825
Closed
+105
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91493784. |
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4825 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 586 586
Lines 61323 61343 +20
=======================================
+ Hits 59309 59330 +21
+ Misses 2014 2013 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: Previously, the transform was not updating the dependents of hierarchical parameters when transfoming the dependent parameters, which leads to errors when constructing the new search space. This diff fixes this by updating the dependents of the parent parameters when their dependents are transformed. Reviewed By: Balandat Differential Revision: D91493784
saitcakmak
force-pushed
the
export-D91493784
branch
from
6fd8aca to
ef72d15
Compare
|
This pull request has been merged in dda11c7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, the transform was not updating the dependents of hierarchical parameters when transfoming the dependent parameters, which leads to errors when constructing the new search space.
This diff fixes this by updating the dependents of the parent parameters when their dependents are transformed.
Differential Revision: D91493784