Add more representative unit tests for load_experiment(skip_runners_and_metrics=True) #4817
+257
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgrange1998 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91349882. |
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4817 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 586 587 +1
Lines 61323 61398 +75
=======================================
+ Hits 59309 59384 +75
Misses 2014 2014 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nd_metrics=True) Summary: Adds testing for skip_runners_and_metrics for with and without reduced_state being specified. Covers unique specific scenarios related to - loading experiment with unregistered metrics in the auxiliary experiment - verifying that loading w/ skipped_runners_and_metric experiment, re-saving and loading again results in loaded metric having base Metric and no runner. Backlog task: T219831930 # Test breakdown Adds three tests below 1. test_load_without_skip_raises_json_decode_error: Tests scenario where auxiliary experiments contain unregistered custom metric types 2. test_load_experiment_with_aux_exp_and_custom_metric_in_gen_metadata - Tests througoughly saving and loading a full experiment with runners, metrics, auxiliary experiments etc. 3. test_resave_experiment_with_aux_exp_loses_custom_metrics_and_runner - Tests the expected data loss when resaving an experiment loaded with skip_runners_and_metrics See post for context: https://fb.workplace.com/groups/aeeng/permalink/1876479416444079/ # Caveat Root cause ``` All PLBO experiments are affected, because they have: PE auxiliary experiments… … that contain serialized `Metric` objects (`Deltoid3Metric` in this case)... … in the `gen_metadata` JSON blobs stored on their generator runs. The error comes up when we try to load affected experiments in AxService, which in turn attempts loading their auxiliary experiments, which have the `Deltoid3Metric` objects that AxService cannot decode. This part of the behavior is correct. Explanation in Q1 below. ``` These tests wouldn't have prevented the above scenario from the post from happening directly, but provide insight and testability into this flow from unit test perspective. # Note Created a new test file instead of extending test_sqa_store.py because the test file will need to be split up soon due to long length. (See backlog task T252573245) Reviewed By: mpolson64 Differential Revision: D91349882
mgrange1998
force-pushed
the
export-D91349882
branch
from
cd06c62 to
76d4ad6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds testing for skip_runners_and_metrics for with and without reduced_state being specified. T219831930
Adds three tests below
JSON Decoding Error
Differential Revision: D91349882