-
Notifications
You must be signed in to change notification settings - Fork 1
Update README and the webpage #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@snipsnipsnip has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 37 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (4)
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughUpdates the Docsify site configuration by removing homepage.md, refactoring index.html with enhanced security attributes and module imports, converting index.mjs to local package imports with new utility functions, and expanding README.md with reorganized changelog and project details. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/site/homepage.md(0 hunks).github/site/index.html(1 hunks).github/site/index.mjs(5 hunks)README.md(3 hunks)
💤 Files with no reviewable changes (1)
- .github/site/homepage.md
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-24T17:47:26.692Z
Learnt from: snipsnipsnip
PR: exteditor/ghostbird#48
File: .github/site/index.mjs:28-39
Timestamp: 2025-10-24T17:47:26.692Z
Learning: In `.github/site/index.mjs`, the `tryRedirect` function's JSON detection using `text.startsWith('{"redirectTo":"')` is intentionally strict and does not need to be tolerant of whitespace or alternative JSON formatting.
Applied to files:
.github/site/index.mjs
🔇 Additional comments (8)
README.md (1)
11-15: LGTM! Excellent documentation improvements.The expanded description clearly explains Ghostbird's purpose and integration with GhostText, and the collapsible changelog section significantly improves readability. The reformatted milestones with consistent indentation and bullet points make the roadmap much easier to scan.
Also applies to: 111-202
.github/site/index.html (2)
3-40: LGTM! Clean, modern HTML structure.The restructured head section with proper formatting, modular script loading, and well-organized metadata improves both maintainability and readability.
Also applies to: 55-61
16-35: Security improvements confirmed; manual hash verification required.The import map and Subresource Integrity (SRI) hashes are properly configured. However, I cannot verify the hashes match the actual CDN resources in this environment. Please manually confirm that each integrity hash in the import map and CSS link corresponds to the correct CDN resource versions before merging.
.github/site/index.mjs (5)
1-2: LGTM! Package imports align with import map.The conversion to package-style imports correctly matches the import map definitions in index.html, enabling better dependency management and SRI protection.
19-19: LGTM! Improved code clarity.The explicit return type documentation and explicit
undefinedreturn improve code clarity without changing functionality. The JSON formatting with spacing is a minor cosmetic improvement.Also applies to: 24-24, 36-36
39-44: LGTM! Simple fix for emoji compatibility.The
fixEmojifunction addresses Docsify's lack of support for the newer nest_with_eggs emoji (Unicode 14.0) by replacing the shortcode with the actual character. The implementation is straightforward and serves its purpose.
49-49: LGTM! Well-structured hook pipeline.The updated pipeline with
tryRedirect(text) ?? addFooter(fixEmoji(text), vm) ?? textcleanly chains redirect handling, emoji fixing, and footer addition. The JSDoc type annotation improves IDE support.Also applies to: 107-111
117-120: LGTM! Proper initialization ordering.Moving mermaid initialization and search plugin loading after the Docsify configuration prevents race conditions and ensures proper setup order. Using
startOnLoad: falsewith manualmermaid.run()invocation in the hook (line 112) gives explicit control over rendering timing.
Also, use SRI and an importmap.
* Copied the introduction text from website * Collapse the roadmap
It seems Docsify isn't happy when the homepage is not named `README.md` as it behaves oddly with plugins. Remove `homepage.md` and simply use the original `README.md` instead.
96f6d33 to
0f90faf
Compare
No description provided.