Planner: reduce complexity

[iseeberg79]

O(n²) -> O(n)

[sourcery-ai]

Hey - I've left some high level feedback:

• Changing continue to return alters the control flow from skipping the rest of the loop iteration to exiting clampRatesSeq entirely; if the intent is just to stop iterating further, consider returning from the iterator callback or breaking out of the loop more locally so the function’s behavior remains clearer to readers.
• Given the claim of reducing complexity from O(n²) to O(n), consider adding a brief code comment near the early-exit condition explaining why no further work is needed once !r.Start.Before(end) is hit, to make the short-circuiting behavior more obvious.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Changing `continue` to `return` alters the control flow from skipping the rest of the loop iteration to exiting `clampRatesSeq` entirely; if the intent is just to stop iterating further, consider returning from the iterator callback or breaking out of the loop more locally so the function’s behavior remains clearer to readers.
- Given the claim of reducing complexity from O(n²) to O(n), consider adding a brief code comment near the early-exit condition explaining why no further work is needed once `!r.Start.Before(end)` is hit, to make the short-circuiting behavior more obvious.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[andig]

go test -bench=. -count 10 > old

# checkout
go test -bench=. -count 10 > new

benchstat old new

goos: darwin
goarch: arm64
pkg: github.com/evcc-io/evcc/core/planner
cpu: Apple M4 Pro
                        │     old      │                 new                 │
                        │    sec/op    │   sec/op     vs base                │
FindContinuousWindow-12   21.126µ ± 1%   6.449µ ± 1%  -69.47% (p=0.000 n=10)
OptimalPlan-12             68.80n ± 1%   68.64n ± 1%        ~ (p=0.469 n=10)
geomean                    1.206µ        665.4n       -44.81%

Oh yeah...